chore: increase min supported java version to 17 #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vovchyk
force-pushed
the
vovchyk/min-java-ver-bump
branch
3 times, most recently
from
47732a3
to
bfe3d65
Compare
Vovchyk
force-pushed
the
vovchyk/min-java-ver-bump
branch
from
bfe3d65
to
e86e8f3
Compare
|
|
pipeline:run |
asoto-iov
reviewed
Jul 25, 2024
| Assertions.assertTrue(channelManager.isAddressBlockAvailable(otherPeer.getInetSocketAddress().getAddress())); | ||
|
|
||
| verify(logger).error(anyString(), any(Throwable.class)); |
There was a problem hiding this comment.
so now, are not we checking if a log was written?
There was a problem hiding this comment.
yes. First, there's a doubt on whether we need to cover logging with unit tests. Second, in this particular case verifying if the logger receives any string seems not to be that useful. And last but not least, starting from java17 it's prohibited to set private static field via reflection (in our case it's a logger)
asoto-iov
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
fed:vovchyk/min-java-ver-bump