Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyValueDataSource#keys() result should allow contains() call #1693

Merged
merged 1 commit into from
Feb 28, 2022
Merged

KeyValueDataSource#keys() result should allow contains() call #1693

merged 1 commit into from
Feb 28, 2022

Conversation

illuque-iov
Copy link

Allow running contains() on KeyValueDataSource#keys() result

Description

Use ByteArrayWrapper as return type of KeyValueDataSource#keys() instead of byte[] to ensure expected behavior: contains() working, etc.

Motivation and Context

#1541

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Vovchyk
Vovchyk previously approved these changes Jan 19, 2022
View reviewed changes
@illuque-iov illuque-iov force-pushed the keyvaluedatasource-keys-implement-allow-contains-operation branch from 89b1662 to 68d7fce Compare February 25, 2022 15:00
Use ByteArrayWrapper as return type of KeyValueDataSource#keys() inst…
9cd6ee1 
…ead of byte[] to ensure expected behavior: contains() working, etc.
@illuque-iov illuque-iov force-pushed the keyvaluedatasource-keys-implement-allow-contains-operation branch from 68d7fce to 9cd6ee1 Compare February 25, 2022 16:38
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@illuque-iov
Copy link
Author

pipeline:run

4 similar comments
@illuque-iov
Copy link
Author

pipeline:run

@illuque-iov
Copy link
Author

pipeline:run

@illuque-iov
Copy link
Author

pipeline:run

@illuque-iov
Copy link
Author

pipeline:run

@Vovchyk Vovchyk merged commit 98f4fd7 into master Feb 28, 2022
@Vovchyk Vovchyk deleted the keyvaluedatasource-keys-implement-allow-contains-operation branch February 28, 2022 09:51
@aeidelman aeidelman added this to the Iris v3.3.0 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vovchyk Vovchyk Vovchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iris 3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@illuque-iov @Vovchyk @aeidelman