-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyValueDataSource.keys() will not work as intended #1541
Comments
For example, LevelDbDataSource.java returns a HashSet. |
It's also possible to change it to a Collection, with potential duplicates. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The method is defined as : public Set<byte[]> keys();
A java byte[] does not implement hashCode() and therefore the resulting map will not support the contains() method (only iteration).
The resulting type should be Set.
The text was updated successfully, but these errors were encountered: