Using 'parameterized tests' for 2wp.js pegin tests #89
Conversation
|
| const legacyPeginTestsHappyPath = [ | ||
| { | ||
| description: 'should do legacy pegin with one input and one output to the federation', | ||
| initialBtcSenderBalancesInBtc: [ MINIMUM_PEGIN_VALUE_IN_BTC ], |
There was a problem hiding this comment.
You can fetch this value using an async function. You just need to execute it once you are executing the test.
| { | ||
| description: 'should do legacy pegin with multiple inputs from different accounts and one output to the federation', | ||
| initialBtcSenderBalancesInBtc: [ MINIMUM_PEGIN_VALUE_IN_BTC, MINIMUM_PEGIN_VALUE_IN_BTC, MINIMUM_PEGIN_VALUE_IN_BTC ], // Each sender is funded with some amount | ||
| btcSenderAmountsToSendToFed: [ MINIMUM_PEGIN_VALUE_IN_BTC, MINIMUM_PEGIN_VALUE_IN_BTC, MINIMUM_PEGIN_VALUE_IN_BTC ], // Each sender decides how much to send to the federation |
There was a problem hiding this comment.
btcSenderAmountsToSendToFed seems a bit complex name to me. Maybe peginSenderAmounts by including pegin, we can assume this refers to funds sent to fed. Wdyt?
| return await Promise.all(sendersInfo.map(senderInfo => rskTxHelper.getBalance(senderInfo.rskRecipientRskAddressInfo.address))); | ||
| }; | ||
|
|
||
| const legacyPeginTestsHappyPath = [ |
There was a problem hiding this comment.
These are not simple legacy pegins. I consider these legacy pegins as border cases, as well as uncommon/complex legacy pegins, at least those ones sending multiple outputs to the fed, since there's no reason for wallet to do that.
That being said, I would add a prefix to this variable like uncommon/complex-LegacyPeginTests . wdyt?
jeremy-then
force-pushed
the
create-new-2wp-file
branch
from
dbea99a
to
13bf6a7
Compare
No description provided.