Change image push method and set tags correctly #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ATarrio
commented
Jul 4, 2024
•
ATarrio
commented
- Use the build-push action to actually push images instead of doing it with a shell command
- Use the generated tags to push them to the registries
- Remove step for setting version, we can just use github_ref_name.
- Upgrade some actions versions to newer ones (like checkout which was giving a deprecation warning)
ATarrio
changed the title
lucasvuotto
suggested changes
Jul 4, 2024
Dockerfile
Outdated
Comment on lines
16
to
21
| RUN gpg --keyserver https://secchannel.rsk.co/SUPPORT.asc --recv-keys 1DC9157991323D23FD37BAA7A6DBEAC640C5A14B && \ | ||
| gpg --verify --output SHA256SUMS SHA256SUMS.asc && \ | ||
| sha256sum --check SHA256SUMS && \ | ||
| ./configure.sh && \ | ||
| ./gradlew --no-daemon clean build -x test && \ | ||
| cp "build/libs/federate-node-$RSK_VERSION-all.jar" rsk.jar | ||
| RUN gpg --keyserver https://secchannel.rsk.co/SUPPORT.asc --recv-keys 1DC9157991323D23FD37BAA7A6DBEAC640C5A14B | ||
| RUN gpg --verify --output SHA256SUMS SHA256SUMS.asc | ||
| RUN sha256sum --check SHA256SUMS | ||
| RUN ./configure.sh | ||
| RUN ./gradlew --no-daemon clean build -x test | ||
| RUN cp "build/libs/federate-node-$RSK_VERSION-all.jar" rsk.jar |
There was a problem hiding this comment.
Please revert this. There is no reason to generate 6 intermediate layers.
ATarrio
force-pushed
the
chalito/update_docker_workflow
branch
3 times, most recently
from
3a26c43
to
f7f803d
Compare
ATarrio
force-pushed
the
chalito/update_docker_workflow
branch
from
b60b01e
to
52098df
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.