Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBalance script example 1 has the wrong input param #106

Closed
RedVelvetZip opened this issue Sep 5, 2024 · 1 comment · Fixed by #107
Closed

getBalance script example 1 has the wrong input param #106

RedVelvetZip opened this issue Sep 5, 2024 · 1 comment · Fixed by #107

Comments

@RedVelvetZip
Copy link
Contributor

Script example 1 (

devportal/docs/02-developers/07-rpc-api/02-methods.md

Line 208 in 42fdd27

- Example request by `blockNumber`:
) claims to use a blockNumber for the second param, while example 2 claims to use a blockHash and example 3 claims to use a blockTag. Script examples 2 and 3 correctly use the params they claim to, but example 1 erroneously had a blockTag instead of a blockHash
@RedVelvetZip RedVelvetZip mentioned this issue Sep 5, 2024
Merged
@ivegabr
Copy link
Collaborator

ivegabr commented Sep 13, 2024

thank you for your comment

@ivegabr ivegabr linked a pull request Sep 13, 2024 that will close this issue
Dev api docs fix param for getbalance example script #107
Merged
@owans owans closed this as completed in #107 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev api docs fix param for getbalance example script RedVelvetZip/devportal
2 participants
@RedVelvetZip @ivegabr