Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segwit poc #61

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Segwit poc #61

wants to merge 14 commits into from

Conversation

julia-zack
Copy link
Contributor

This branch was created to make the change the fed address into a segwit-compatible one.
For now,

  1. Create a new method (called createP2SHP2WSHOutputScript) in ScriptBuilder class that creates the output script for a P2SH-P2WSH
  2. Add a test to compare our calculation for a P2SH-P2WSH address against the one obtained with electrum
  3. Rename existing function sha256hash160 to simply hash160 and replace it where needed. This makes sense since hash160 by definition first makes a sha256 encryption.

marcos-iov and others added 14 commits July 21, 2023 16:43
@marcos-iov
Create new method createP2SHP2WSHOutputScript
e1095b5
@julia-zack
Replace sha256hash160 with hash160. Refactor
cb9577c
@marcos-iov
Use createP2SHOutputScript implementation that receives the script
11b9183
@julia-zack
Add test for function hash160
e7fcfe7
@julia-zack
Add createWitnessScript and needed constructor values into TxWitness …
5bc92f6 
…class
@marcos-iov
Merge pull request #62 from rsksmart/modify_TransactionWitness
c304dcb 
Add signatures in witnessScript
@julia-zack
Add hashForWitnessSignature, createWitnessErpScript and createP2shP2w…
b5369f1 
…shErpRedeemScript
@marcos-iov
Update src/main/java/co/rsk/bitcoinj/core/TransactionWitness.java
1d15303
@marcos-iov
Merge pull request #63 from rsksmart/sign_with_witness_fed
8045905 
Sign with witness fed
@julia-zack
Add witnessEmergencyScript, remove OP_0NOTEQUAL from redeem and refac…
38ec8fa 
…tor the byte pushed for op_notif argument
@julia-zack
Correct OP_NOTIF argument
fcdb7c2
@marcos-iov
Merge pull request #64 from rsksmart/refactor_and_add_scripts
c94b9e6 
Add witnessEmergencyScript, remove OP_0NOTEQUAL from redeem and refactor the byte pushed for op_notif argument
@marcos-iov
Add function to create a flyover p2wsh script
25f6d80
@marcos-iov
Merge pull request #66 from rsksmart/add_reedem_with_flyover
a70f5ee 
Add reedem with flyover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julia-zack @marcos-iov