Fast Bridge #175
Open
Fast Bridge #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidohernan93
force-pushed
the
fast-bridge
branch
from
84d4049
to
ee4cc04
Compare
guidohernan93
force-pushed
the
fast-bridge
branch
from
ee4cc04
to
a342e6c
Compare
guidohernan93
force-pushed
the
fast-bridge
branch
from
51f8884
to
cefcb5c
Compare
|
|
||
| The system comprises one or more liquidity providers (LPs), listed in an onchain marketplace. Interactions with LPs are intermediated using a dApp or a website. | ||
|
|
||
| #### Liquidity Providers contract |
There was a problem hiding this comment.
Please include the Solidity interface for this.
e.g.
interface ILiquidityBridgeContract {
transferStatus(bytes32[]) return uint;
transferFunds(bytes32[]);
}
|
|
||
| #### registerBtcTransfer() | ||
|
|
||
| **Parameters**: |
There was a problem hiding this comment.
Please include the ABI signature for this method
IPs/RSKIP175.md
Outdated
| - *byte[]* btcTxSerialized: Serialized Bitcoin transaction | ||
| - *int* height: Block number where the transaction is present | ||
| - *byte[]* pmtSerialized: Serialized partial merkle tree | ||
| - *Sha256Hash* derivationArgumentsHash: A hash created from all the derivation arguments |
There was a problem hiding this comment.
Suggested change
| - *Sha256Hash* derivationArgumentsHash: A hash created from all the derivation arguments | |
| - *Sha256Hash* derivationArgumentsHash: A hash created from the derivation arguments |
It's not all the derivation arguments, only those not required by the Bridge
| - If status obtained is **OK**, will check if Locking Cap value is surpassed: | ||
| - If not surpassed, will transfer funds to Liquidity Bridge Contract | ||
| - If surpassed, will refund Liquidity Provider | ||
|
|
There was a problem hiding this comment.
It seems that there are a few missing steps.
- There should be validation to determine if the UTXO to the derive Fed was already registered.
- There should be a step to register the UTXO
|
|
||
| ### Federation Address Derivation | ||
|
|
||
| The address derivation process will be carried out by creating a custom redeem script that will make a push of a 32 bytes hash created from the provided derivation arguments. That data is then dropped. |
There was a problem hiding this comment.
You could add a clarification that this custom redeem script is executed in the same way to the standard one, allowing the same Federation members to sign the releases of these ad-hoc Federations.
guidohernan93
force-pushed
the
fast-bridge
branch
from
4e201ee
to
2d70e2e
Compare
IPs/RSKIP175.md
Outdated
| receiverAddress.transfer(msg.value); | ||
| } | ||
|
|
||
| The Solidity interface for this cotract must be: |
There was a problem hiding this comment.
Suggested change
| The Solidity interface for this cotract must be: | |
| The Solidity interface for this contract must be: |
IPs/RSKIP175.md
Outdated
|
|
||
| interface ILiquidityBridgeContract { | ||
| transferStatus(bytes32) return uint; | ||
| transferFunds(bytes32) external payable; |
There was a problem hiding this comment.
Suggested change
| transferFunds(bytes32) external payable; | |
| transferFunds(bytes32) payable; |
guidohernan93
force-pushed
the
fast-bridge
branch
3 times, most recently
from
78e207b
to
469c45a
Compare
guidohernan93
force-pushed
the
fast-bridge
branch
from
469c45a
to
da83506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.