Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update the glibc version we use for aarch64 #3693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Contributor

No description provided.

@DilumAluthge DilumAluthge marked this pull request as ready for review February 18, 2024 06:17
@DilumAluthge
Copy link
Contributor Author

Hat-tip @staticfloat for providing this fix.

@DilumAluthge
Copy link
Contributor Author

Okay, so the original issue (the glibc problem) seems to be fixed. But now there's a new test failure.

@Keno Is this test failure expected?

@Keno
Copy link
Member

Keno commented Feb 18, 2024

The glibc that comes with the rootfs likely wasn't built with -moutline-atomics (or more likely with a GCC version that doesn't have the initializer priority fix) which is required for rr to work. I think the way to fix this will be to bump the glibc version in Yggdrasil and then bumping the version here. Yggdrasil builds these things with rr compatibility.

@DilumAluthge DilumAluthge marked this pull request as draft February 18, 2024 07:02
@rocallahan
Copy link
Collaborator

So the patched glibc didn't work with the version of lldb or its dependencies that you tried to install? Can we just install a different version of lldb and not upgrade glibc?

@Keno
Copy link
Member

Keno commented Feb 18, 2024

We periodically bump the base debian version that we use to build the CI root images, but we didn't bump the rr ci config when that happened last, so it was still on old debian. So the new debian has a newer glibc than the patched one that we had prepared for rr. We could build an old debian with lldb, but I think building newer glibc is probably easier, since that's all automated. Otherwise the rr ci would need a special snowflake rootfs build for the older debian.

@Keno
Copy link
Member

Keno commented Feb 18, 2024

@DilumAluthge do you know what needs to be done for the glibc bump or do you need me to take care of it?

@DilumAluthge DilumAluthge changed the title CI: remove the "patch glibc host environment" step on aarch64 CI: update the glibc Feb 19, 2024
@DilumAluthge DilumAluthge changed the title CI: update the glibc CI: update the glibc version we use for aarch64 Feb 19, 2024
@DilumAluthge DilumAluthge marked this pull request as ready for review February 19, 2024 19:35
@rocallahan
Copy link
Collaborator

Looks like this PR is still failing.

I know you guys are busy but I hope we can get this fixed

@staticfloat
Copy link
Contributor

It appears that when we unpack the new DebianGlibc version over the top of the rootfs it replaces /usr/include/string.h (along with all the other includes) but the compiler is complaining about that:

/usr/include/string.h:467:5: error: expected , or ; before __fortified_attr_access
 467  |     __fortified_attr_access (__write_only__, 1, 2);
      |     ^~~~~~~~~~~~~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants