-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For upstream/avoid useless cleanup #2003
base: master
Are you sure you want to change the base?
Conversation
…istry classes, beacause it's impacting performance, and it's redundant with the workers' maintenance task that already calls cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
- Coverage 93.84% 93.82% -0.02%
==========================================
Files 29 29
Lines 3897 3889 -8
==========================================
- Hits 3657 3649 -8
Misses 240 240
☔ View full report in Codecov by Sentry. |
If you really need to disable this, I suggest adding a |
Ah that's a good point.
Well, "executes very quickly" doesn't tell me a lot 🙂
It's not a very usable solution, as What if instead,
Would you be happy with that? |
Sorry, I forgot that it's a property. In that case do you mind opening a PR that adds a
|
Thanks for your answer, I understand your position. |
I think implementing |
Have come across a problem that is somewhat related to what is being discussed this PR. The cleanup also causes problems when calling get_statistics() using a custom serializer for the queue. When One solution is to remove this cleanup in I can open a PR for the second option if that is the preferred solution. If the first option is preferred, it would be great to get a timeframe of when a fix will be implemented. Let me know! |
It's impacting performance, and it's redundant with the workers' maintenance task that already calls
cleanup