Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1602 mentions that if a worker crashes with a work horse still running, the work horse process, when the job finishes will attempt to update stats.
By default Redis creates keys with no expiration, resulting in a new worker key being created that makes it so you can't re-register a worker with the same key. The worker is also in an odd state, neither alive or dead.
Mentioned in the issue is a suggesting to optimize this to avoid an extra Redis call by checking if the value was set to 1, but I'm not sure this will work as that will also catch the situation of the first job a worker runs, resulting in the number never being incremented.