Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multiple databases with ActiveRecord #618

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

n-studio
Copy link

@n-studio n-studio commented Jul 3, 2021

@benlangfeld
Copy link
Collaborator

benlangfeld commented Jul 5, 2021

Is there a way we can test this?

Please also include a changelog entry :)

@n-studio
Copy link
Author

n-studio commented Jul 6, 2021

Is there a way we can test this?

Please also include a changelog entry :)

I updated the changelog entry. I have no idea how to test it, but if you have an idea I can implement it.

@benlangfeld
Copy link
Collaborator

@aried3r How much do you care about test coverage for this, considering the difficulty in setting up multiple databases in CI?

@aried3r
Copy link
Member

aried3r commented Jul 9, 2021

I haven't yet needed to test multi-db Rails setups on CI myself, so I have to ask naively, shouldn't it be – at least for PostgreSQL – "just" another call do createdb?

I don't want to test Rails itself, but if there was even a single test that confirms that two DBs are being used, I'd appreciate it.

Could we also add a little bit of documentation to the README?

@nicdal
Copy link

nicdal commented Oct 19, 2023

Any plans to merge this to master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple databases support
4 participants