This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add Production View #50
Open
robere2
wants to merge
19
commits into
master
Choose a base branch
from
fix-issue-45
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a button that displays tags when clicked on, tags themselves are buttons but do nothing. Could also possibly have the wrong angle bracket. Getting the warning: runtime-core.esm-bundler.js:38 [Vue warn]: Invalid prop: type check failed for prop "tags". Expected Array, got Undefined at <ProductionTags tags=undefined > However, it doesn't seem to matter? Unsure if I can merge line 17 with 18 in any way. Used hr element instead of the divider component from naive because there are no color props in it.
Fixed a large portion of css issues. Changed width of the card because it felt too big when at 80%. Solved why the video player was so poorly sized. Added functionality to arrow buttons to scroll to the next item in the carousel. Didn't remove the national geographic giraffe or the randomizer image.
…. Hide carousel if no items are available
productionTags now clearly tells users if the production has no tags. productionCredits adds credits to all users in the production, added media queries along with it, and default profile pictures.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to view Individual productions at the route
/productions/:id
. This closes rpitv/glimpse#23.Design is similar to what was proposed in the original issue, but was changed in a few minor ways:
Tags and credits are not displayed when they are empty.
Issues which should probably be created when this is merged: