Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Add Production View #50

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add Production View #50

wants to merge 19 commits into from

Conversation

robere2
Copy link
Member

@robere2 robere2 commented Dec 31, 2022

This PR adds the ability to view Individual productions at the route /productions/:id. This closes rpitv/glimpse#23.

Design is similar to what was proposed in the original issue, but was changed in a few minor ways:

  • Major UI components are not styled beyond the default Naive UI styling.
  • Credits do not have a profile picture yet, as the Person data type doesn't have a profile picture field.

image
image

Tags and credits are not displayed when they are empty.

Issues which should probably be created when this is merged:

  • Profile pictures should be added to credits
  • Clicking on a user's name in the credits should bring you to their profile
  • HLS and RTMP video feed support
  • Tag improvements
    • They're a bit hard to read in their current colors. Check W3 accessiblity standards (we shoot for WCAG AA minimum).
    • They are buttons, but clicking them doesn't do anything.
  • Markdown for when no video player is present (e.g. custom messages/links when no video available, or when video not embeddable)
  • Data visible to members only
    • RSVP list, and ability to RSVP yourself
    • Edit button
    • Closet location
    • Closet time
    • Team notes
    • Link to Discord channel?
  • Public chat?
    • We can embed the YouTube chat for YouTube events, and for events which are streamed on our own video player we can add our own chat.
    • Optionally, we could make it so you have to log in to chat. This would make it easier to moderate, but would limit user interaction.
    • This should be pretty low on the priority list, but something worth thinking about.

robere2 and others added 19 commits November 22, 2022 21:00
Made a button that displays tags when clicked on, tags themselves are buttons but do nothing. Could also possibly have the wrong angle bracket.

Getting the warning:
runtime-core.esm-bundler.js:38 [Vue warn]: Invalid prop: type check failed for prop "tags". Expected Array, got Undefined
  at <ProductionTags tags=undefined >

However, it doesn't seem to matter?

Unsure if I can merge line 17 with 18 in any way.

Used hr element instead of the divider component from naive because there are no color props in it.
Fixed a large portion of css issues. Changed width of the card because it felt too big when at 80%.
Solved why the video player was so poorly sized.
Added functionality to arrow buttons to scroll to the next item in the carousel.
Didn't remove the national geographic giraffe or the randomizer image.
productionTags now clearly tells users if the production has no tags.

productionCredits adds credits to all users in the production, added media queries along with it, and default profile pictures.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production Page
2 participants