Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PluginManagerExtention #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create PluginManagerExtention #43

wants to merge 2 commits into from

Conversation

niokasgami
Copy link
Contributor

Add two new I think Must function to the PluginManager for help more code cleaning
From my actual pluginManager but I think those two methods are the most important to be implemented.
who are
"ToBoolean" who cope the fact it's return a true boolean without having to do the string splitting on the variable declaration which is messy.

"ToArray" Allow the use Array in plugin parameters box

Add two new I think Must function to the PluginManager  for help more  code cleaning 
From my actual pluginManager but I think those two methods are the most important to be implemented.
who are 
"ToBoolean" who cope the fact it's return a true boolean without having to do the string splitting on the variable declaration which is messy.

"ToArray" Allow the use Array in plugin parameters box
* @param {string} parameters
* @returns {Array<any>}
*/
Pluginmanager.toArray = function (plugin, parameters) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? Pluginmanager

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad lol hahah I guess I just made a little typoe without noticing will fix that

Updated the pluginManager extentions because it as a typo I didn't notice lol
@ghost
Copy link

ghost commented Mar 15, 2017

Just a small note: I think the correct spelling is "Extension"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants