fix sound not playing under certain operations (smartphone) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinknathan
pushed a commit
to thinknathan/corescript
that referenced
this pull request
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a
WebAudio._onVisibilityChangeproblem.WebAudio._onHideandWebAudio._onShowadjust the volume when the browser visibility changes for Smartphone (especially Android OS).But,
WebAudio._onHideand `WebAudio._onShow have different fade duration.The following operations will cause problems.
WebAudio._onHide)When this operation is performed, the fade-out time will be longer than the fade-in time.
Then the sound will be muted all the time 😢