Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover exception by undefined _progressListener #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayamada
Copy link

@ayamada ayamada commented Apr 16, 2019

Raises Object doesn't support property or method '_progressListener' exception in rare cases on microsoft edge browser.

Possibly, _bitmapListener or _audioListener were executed BEFORE setProgressListener.

I suppose to can omit to execute _progressListener when not have _progressListener.

Sorry for my poor english.

@krmbn0576
Copy link
Collaborator

It sounds good, thanks!
By the way, do you know why the _bitmapListener or _audioListener were executed BEFORE setProgressListener, and why only in Edge? (just for future reference ;-)

@ayamada
Copy link
Author

ayamada commented Apr 16, 2019

Sorry, I don't know that.
(I don't have microsoft edge browser environment, now)
But, I am suspicious of behaviour by Graphics._cssFontLoading in Graphics.js.
Because, microsoft edge browser don't support document.fonts.ready.then as saying by https://developer.mozilla.org/ja/docs/Web/API/Document/fonts .

Copy link
Collaborator

@krmbn0576 krmbn0576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly that may be relevant.
Thanks!

thinknathan pushed a commit to thinknathan/corescript that referenced this pull request Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants