-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic solaire mode functionality #78
base: master
Are you sure you want to change the base?
Conversation
Thanks! Do you know if it is possible to darken the header line as well in solaire mode? |
Yes, I've been trying to implement it, but it's been rather difficult due to the way the faces in I found a way to make it work, but it's extremely cumbersome:
`face '(:background (face-background `header-line)
:foreground (face-foreground `nano-face-header-default)
:weight (face-attribute`nano-face-header-default :weight)) You cannot simply inherit from The best way would probably be to rewrite |
From commit [c43b36](https://github.com/rougier/nano-emacs/pull/78/commits/c4d3b46be3c04af217f2f5debe1ab50ef05552c50 the modeline now updates properly, but it did include changing the modeline function somewhat, but luckily less than I'd feared. Ideally we would set some new colors for the header-line background and foreground face, the current implementation works alright, but it'd be better to lighten the text in the light-theme somewhat, and darken it in the dark-theme. There's probably some clever function you can write for that, but I don't currently know how to, very happy to hear your suggestions! |
Wonderful! I'm not sure we can modify the text color without adding a new specific face and I would prefer to avoid that for such a specific case. I think your PR is ready to be merged for me. If you're happy with it, I'll merge. |
I'm happy enough with it, you can merge it! |
With the new modeline I managed to have active/inactive face for the header or mode line. Hopefully, this should solved the problem with solaire. |
This PR adds the minimum to work with solaire-mode, which darkens non-file-visiting buffers. The values are picked somewhat arbitrarily, but they look nice I think. Should not conflict with non-solaire-mode users.
Dark
Light