Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construction mod path fails for names with underscores #74

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Construction mod path fails for names with underscores #74

merged 2 commits into from
Feb 28, 2024

Conversation

jsiefer
Copy link
Contributor

@jsiefer jsiefer commented Feb 27, 2024

e.g. /example/my_module.rs resulted in my/mod.rs not my_module/mod.rs

Code example
https://onecompiler.com/lua/425ppcxp6

@jsiefer
Construction mod path fails for names with _
e7e1142 
e.g. /example/my_module.rs  resulted in my/mod.rs not my_module/mod.rs
rouge8
rouge8 requested changes Feb 27, 2024
View reviewed changes
Copy link
Owner

@rouge8 rouge8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@jsiefer
Copy link
Contributor Author

jsiefer commented Feb 28, 2024

there you go

rouge8
rouge8 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Owner

@rouge8 rouge8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rouge8 rouge8 merged commit 9e9df68 into rouge8:main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouge8 rouge8 rouge8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsiefer @rouge8