Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod path when both mod file and mod dir exist #68

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Frederick888
Copy link
Contributor

When both src/parent.rs and src/parent/ exist, construct_mod_path can be
called with construct_mod_path('src/parent.rs', 'child'). In this case
it should return src/parent/child.rs instead of nil.

Closes #60

@Frederick888 Frederick888 marked this pull request as ready for review January 2, 2024 15:04
Copy link
Owner

@rouge8 rouge8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

When both src/parent.rs and src/parent/ exist, construct_mod_path can be
called with construct_mod_path('src/parent.rs', 'child'). In this case
it should return src/parent/child.rs instead of nil.
@Frederick888
Copy link
Contributor Author

Please add a test

Done 👌

@rouge8 rouge8 merged commit 3c06f23 into rouge8:main Jan 3, 2024
2 checks passed
@rouge8
Copy link
Owner

rouge8 commented Jan 3, 2024

Thanks!

@Frederick888 Frederick888 deleted the fix-mod-path branch January 3, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug fails because file_path is nil
2 participants