fix(errors): handle diagnotics from latest version of nextest #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorlfs
changed the title
Merged
|
Hey @rouge8, any thoughts? |
This was referenced Jan 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update diagnostic handling to work with the latest versions of nextest. Besides updating the match and the test, I also updated some "build_spec" tests and their respective XMLs (so that the tests are passing; I'm not sure if updating the XMLs directly is a good idea).
I'm not really proficient with Lua patterns, so I've hard-coded the match containing the message to capture all lines up to a line containing 'note' -- that's far from elegant, it'd be nice to at least handle the case where RUST_BACKTRACE is set and a line with 'stack' should be used instead. But still, there must be a better way to do that.
Preview: