Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements to climate: add support for fans, add support for simpler ACs and specifically for Friedrich ACs #1473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ncd7
Copy link

@ncd7 ncd7 commented Aug 16, 2023

Tested in my HA.
Unsure how to test the many other climate entities out there in the wild to make sure I haven't broken anyone else.
NB: there is still an outstanding bug with units in Fahrenheit where you cannot change the temperature. The bug seems somewhere deeper inside localtuya and beyond my ability to address with this PR.

@ncd7
Copy link
Author

ncd7 commented Aug 17, 2023

Does anyone know if I'm supposed to trigger the tests first somehow? I poked around but didn't see an option.

@ncd7 ncd7 changed the title enhancements to climate: add support for fans, add support for Friedrich Unifit AC enhancements to climate: add support for fans, add support for simpler ACs and specifically for Friedrich ACs Aug 17, 2023
@jmcollin78
Copy link

Hello @ncd7,

This helps me a lot. Very sad that this PR is not merged.
Do you think this PR have a chance to be merged one day ?

@ncd7
Copy link
Author

ncd7 commented May 28, 2024

Hello @ncd7,

This helps me a lot. Very sad that this PR is not merged. Do you think this PR have a chance to be merged one day ?

Apologies, I missed this. Unlikely and with the upcoming changes to the constants, it seems this will not fair well.
However, it appears there's an alternative localtuya repo which is being much more actively updated so perhaps I'll move the PR to it.
I have a weekend TODO to move to the new integration - I'm just nervous about breaks.

@jmcollin78
Copy link

Hello @ncd7,
This helps me a lot. Very sad that this PR is not merged. Do you think this PR have a chance to be merged one day ?

Apologies, I missed this. Unlikely and with the upcoming changes to the constants, it seems this will not fair well. However, it appears there's an alternative localtuya repo which is being much more actively updated so perhaps I'll move the PR to it. I have a weekend TODO to move to the new integration - I'm just nervous about breaks.

Have you a link to the new integration ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants