Combined search/list deps page #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkent
force-pushed
the
1-expand-deps-search-fields
branch
from
08e819d to
3e120e0
Compare
|
Sorry for the revision, I discovered some unneeded code to remove. |
Signed-off-by: R. Kent James <[email protected]>
rkent
force-pushed
the
1-expand-deps-search-fields
branch
from
3e120e0 to
6c9afa4
Compare
|
Oops, sorry again for the redo, had to remove some spaces from blank lines. |
|
Thanks this sounds like a good step forward. @rkent Did you have a chance to run a test build for this? |
|
Yes, this can be seen at https://index.rosdabbler.com/search_deps/ The 'search_deps' is not enabled in the UI, you need to enter it directly like this. |
|
@tfoote is there something I can do to move this forward? I can't really expose the new package search until this is also landed. |
tfoote
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tabulator-based combined list and search page for system dependencies. Much of this is a copy of what we did with the package list page. This does not show this new page in the UI (like with package list), to view it you need to enter
/search_deps/It adds additional fields to deps, allow searching by upstream package name, platform, ROS package dependant, in addition to dep name and description. I'm not sure system dependency search needs all of this, but it was not difficult to add.
This removes the sharding from the search data for deps, which also affects the existing search page. The size still seems managable. It will eventually be smaller once we remove the old search pages, as there is a lot of extraneous information in the data and index that was used by the old search page, but is not needed by the new one.
Although largely copied from the new package search page, there are two new features here that I also intend to add to the package search: initial sort by search score, and an extensive help page.
Our power is out which affects my build farm, so I am unable to run a non-development build with this for demo, but I will do that as soon as the power is restored.