Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eia_data() refactor: dynamic error handling, forced input format requirements, and additional unit testing #18

Merged
merged 6 commits into from
Nov 17, 2023
Merged

eia_data() refactor: dynamic error handling, forced input format requirements, and additional unit testing #18

merged 6 commits into from
Nov 17, 2023

Commits on Nov 17, 2023

  1. for start and end to be character (the only technically applicabl… 

    …e numeric values would be year of format YYYY - everything else requires character); similarly, force `length` and `offset` to be numeric - no reason to test for both; update docs.
    @mghoff
    mghoff committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    1d8cfa2 View commit details
    Browse the repository at this point in the history

  2. slightly better error message - if no data is returned, most likely c… 

    …ause is bad inputs to `start`/`end`
    @mghoff
    mghoff committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f9a7da9 View commit details
    Browse the repository at this point in the history

  3. add tests for varying temporal resolution of returned data based on `… 

    …freq`, `start`, and `end` input values
    @mghoff
    mghoff committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5f64ff4 View commit details
    Browse the repository at this point in the history

  4. error: check temporal inputs

    @mghoff
    mghoff committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3925bff View commit details
    Browse the repository at this point in the history

  5. update DESCRIPTION, NEWS, and codemeta for version bump

    @mghoff
    mghoff committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    89cfd76 View commit details
    Browse the repository at this point in the history

  6. Update CRAN comments and revdep check.

    @leonawicz
    leonawicz committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d000e3d View commit details
    Browse the repository at this point in the history