Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AllocatedValue and make it more dynamic. #153

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix AllocatedValue and make it more dynamic. #153

wants to merge 6 commits into from

Commits on Jun 28, 2017

  1. Use offsetof for payload calculation.

    @marsupial
    marsupial committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    e99040c View commit details
    Browse the repository at this point in the history

  2. Be strict about Value payload alignment…v-tables may be going in there!

    @marsupial
    marsupial committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    ef72a06 View commit details
    Browse the repository at this point in the history

  3. Make sure to run ~AllocatedValue, who knows what the compiler has done…

    @marsupial
    marsupial committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    bf59a74 View commit details
    Browse the repository at this point in the history

  4. Fix AllocatedValue for cases when constructor or cling::printValue ha… 

    …s thrown/failed.

Previous implementation was both non-conforming and could easily lead to a crash.
By delivering a memory as a char buffer, and allowing the client to write into the -1 slot,
ValuePrinterSynthesizer can mark that construction has succeeded and the destructor can be called.

Additionally this change hides most implementation details of AllocatedValue from cling::Value.
    @marsupial
    marsupial committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    c7f5024 View commit details
    Browse the repository at this point in the history

  5. Make AllocatedValue allocate memory more dynamically based on the nee… 

    …ds of the type.
    @marsupial
    marsupial committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    cb52557 View commit details
    Browse the repository at this point in the history

  6. Fixes for CERN/master. 

    Currently the bit is not being set in ValueExtractionSynthesizer which would mean no destructor would ever run!
    @marsupial
    marsupial committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    9441c77 View commit details
    Browse the repository at this point in the history