Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ownerDocument from node, use restProps on parent node, set mode to immutable #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use ownerDocument from node, use restProps on parent node, set mode to immutable #164

wants to merge 1 commit into from

Conversation

nathanfaucett
Copy link

  • use el.ownerDocument of mounted element to insure local document tree
  • pass $$restProps to parent div to allow adding attributes to root portal element
  • use immutable mode since target props does not require mutations to be allow

@nathanfaucett nathanfaucett changed the title use ownerDocument or node, use restProps on parent node, set mode to immutable use ownerDocument from node, use restProps on parent node, set mode to immutable Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nathanfaucett