Split up converter.rs into AST nodes #5510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Initially, the Rust side of the AST converter was mostly a single file,
converter.rs
, spanning several thousand lines of code. My goal, however, is to structure the Rust side similarly to the TypeScript side by co-location AST node related code.This PR will create a separate Rust file for each (ESTree) AST node as with Rust, it is possible to split up the AstConverter implementation over as many files as we like. In the future, related tree-shaking and rendering logic can be placed within the same files, making it easy to see the lifetime of an AST node in one place.