[joomla#43505] Fixed not reading the changelog URL

Signed-off-by: Roland Dalmulder <[email protected]>
roland-d · Dec 16, 2024 · 00a1a52 · 00a1a52
1 parent c59e8ce
commit 00a1a52
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/libraries/src/Changelog/Changelog.php b/libraries/src/Changelog/Changelog.php
@@ -372,7 +372,7 @@ public function loadFromXml($url)
         xml_set_element_handler($this->xmlParser, 'startElement', 'endElement');
         xml_set_character_data_handler($this->xmlParser, 'characterData');
 
-        if (!xml_parse($this->xmlParser, $response->body)) {
+        if (!xml_parse($this->xmlParser, $response->getBody()->getContents())) {
             Log::add(
                 \sprintf(
                     'XML error: %s at line %d',

diff --git a/libraries/src/Http/Transport/CurlTransport.php b/libraries/src/Http/Transport/CurlTransport.php
@@ -260,6 +260,7 @@ protected function getResponse($content, $info)
 
         $streamInterface = new StreamResponse('php://memory', 'rw');
         $streamInterface->write($body);
+        $streamInterface->rewind();
 
         return new Response($streamInterface, $statusCode, $verifiedHeaders);
     }

diff --git a/libraries/src/Http/Transport/SocketTransport.php b/libraries/src/Http/Transport/SocketTransport.php
@@ -176,6 +176,7 @@ protected function getResponse($content)
 
         $streamInterface = new StreamResponse('php://memory', 'rw');
         $streamInterface->write($body);
+        $streamInterface->rewind();
 
         return new Response($streamInterface, $statusCode, $verifiedHeaders);
     }

diff --git a/libraries/src/Http/Transport/StreamTransport.php b/libraries/src/Http/Transport/StreamTransport.php
@@ -209,6 +209,7 @@ protected function getResponse(array $headers, $body)
 
         $streamInterface = new StreamResponse('php://memory', 'rw');
         $streamInterface->write($body);
+        $streamInterface->rewind();
 
         return new Response($streamInterface, $statusCode, $verifiedHeaders);
     }