Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature/pass-spec-directly #356

Open
wants to merge 2 commits into
base: feature/pass-spec-directly
Choose a base branch
from

Conversation

serut
Copy link
Contributor

@serut serut commented Apr 14, 2024

This MR fixes #347

  • remove getIsExternalUrl function
  • add themeId to ApiSchema
  • add downloadSpecUrl property to RedocProps and co, to separate the behavior from url that was doing 2 different things
  • improve doc with new usage

Copy link

changeset-bot bot commented Apr 14, 2024

⚠️ No Changeset found

Latest commit: 5984190

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 14, 2024

@serut is attempting to deploy a commit to the Rohit Gohri's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant