Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon Colliders, proper offsets #2

Merged
merged 4 commits into from
Jul 2, 2018

Conversation

richardkopelow
Copy link
Contributor

I made some modifications to make the closed shape colliders (capsule, ellipse, rounded box, star) use the polygon collider rather than the edge collider. This makes them solid like the primitive colliders rather than hollow.

The offsets very for the ones I changed were over correcting. The collider points were offset by the object's position. This is an over correction so I removed that part.

…pe colliders to use the polygon collider instead of the edge collider.
@Vuwij
Copy link

Vuwij commented Oct 30, 2016

Hi Richard, I made the same modification as you did, but since yours is more updated, we should just use yours.
Another suggestion that I did on my pull request, use OnGUI to hide the polygon collider, as we aren't using it

…at lets you punch in any value for radii rather than using the sliders that are clipped between 1 and 25. I also fixed a bug with the thickness of the arc collider.
@richardkopelow
Copy link
Contributor Author

I added a commit to this pull request to address to address #1 and #5. @GuyQuad please take a look at this, see if you want it merged in.

@GuyQuad GuyQuad merged commit e517e0b into rohangaikwad:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants