Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NBA stats table CSS selector #764

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vgeek
Copy link

@vgeek vgeek commented Dec 1, 2022

This changes CSS selector for NBA team names/abbreviations.

closes #691

@jakesjordan00
Copy link

Still does not work for me unfortunately

@vgeek
Copy link
Author

vgeek commented Dec 2, 2022

Can you confirm the actual error? Try changing line 60 in openers.py from
raise HTTPError(resp.url, resp.status_code, resp.reason, resp.headers, None)
to
raise Exception(resp.status_code)

and confirm that you're not getting a 429 error for rate limiting or some other error.

@roclark roclark self-assigned this Dec 4, 2022
@roclark roclark added the bug Something isn't working label Dec 4, 2022
@roclark roclark added this to the Release 0.6.1 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teams class from the NBA package seems to be broken.
3 participants