Use eth in queue #255
Open
Use eth in queue #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deposit pool space - Also allows assignment to scale with value of deposit
- 2 comments in PR - Need for a hard max on assignments to ensure there's enough gas in a block - Unrelated; did away with the weird counter-spanning-for-loops trick to be more explicit
Comments implied it could be used either by anyone when an NO failed to move forward in prelaunch OR by the NO at that same time or while in queue. However, the functionality only allowed the former. Updated code/comments to explicitly only do the former.
- No longer supports 32E deposits - Will support any deposit size the same way (eg, 16E or 8E)
Valdorff
force-pushed
the
use_eth_in_queue
branch
from
10cd226
to
d64da92
Compare
|
Force push fixed an error in deposit. I had subtracted the 1 ETH used for prestake from the balance instead of the deposit. My b. |
Valdorff
commented
Aug 19, 2022
Comment on lines
+57
to
+59
| function setStakingQueueETHBalance(uint256 _value) private { | ||
| setUint(keccak256("network.balance.queuestaking"), _value); | ||
| } |
There was a problem hiding this comment.
oDAO could calculate this as:
- a =
sum of nodeDepositBalance across efficient queue(equivalently, sum of nodeDepositBalance where nodeDepositAssigned==False) - b=
number of minipools in efficient queue(accounts for the 1 scrub ETH) - c =
total user-deposited ETH since last assignment stakingQueueETHBalance = a - b - c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design PR
Benefits:
RocketNodeDeposit.getDepositTypeto consider another deposit amount valid.TODO