- fixed srcset in blueprint: image => files field

- test srcsets
- test multilang route
- ignored coverage: x-language detect since header is too hard to fake

Signed-off-by: Bruno Meilick <[email protected]>

.gitignore

@@ -7,7 +7,7 @@
 /tests/logs
 /tests/media
 /tests/site/accounts
-/tests/site/session
+/tests/site/sessions
 /tests/site/cache
 
 # files of Composer dependencies that are not needed for the plugin

classes/Betterrest.php

@@ -69,13 +69,15 @@ public function contentFromRequest(?\Kirby\Http\Request $request = null): ?array
         $request = $request ?? $this->kirby->request();
         $path = preg_replace('/rest/', '', (string)$request->path(), 1);
 
+        // @codeCoverageIgnoreStart
         // auto detect language
         if (! \Kirby\Toolkit\A::get($this->options, 'language')) {
             $language = $request->header('x-language');
             if ($language) {
                 $this->options['language'] = $language;
             }
         }
+        // @codeCoverageIgnoreEnd
 
         // if has language and is multilang setup...
         $language = \Kirby\Toolkit\A::get($this->options, 'language');
@@ -147,7 +149,7 @@ public function applyKirbytags(?string $value): string
 
     /**
      * @param $value
-     * @return string
+     * @return array
      */
     public function applySrcSet($value): array
     {

composer.json

@@ -2,7 +2,7 @@
   "name": "robinscholz/better-rest",
   "description": "Kirby Plugin for better REST requests",
   "type": "kirby-plugin",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "license": "MIT",
   "authors": [
     {

tests/BetterrestTest.php

@@ -65,10 +65,16 @@ public function testContentModification()
         $this->assertNull($rest->modifyContent([]));
 
         $data = $rest->modifyContent($rest->content);
+
+        $this->assertIsArray($rest->getOptions()['srcset']);
+        $this->assertRegExp(
+            '/^\/media\/pages\/test\/.*(375w,).*(667w,).*(1024w,).*(1680w)$/',
+            $data['data']['content']['testimage'][0]['srcset']
+        );
+
+        $this->assertIsArray($data);
         $rest->setData($data);
         $this->assertTrue($rest->getData() === $data);
-
-        $this->assertIsArray($rest->data);
     }
 
     public function testNoDataResponse()

tests/IndexTest.php

@@ -39,10 +39,14 @@ public function testFindsTestPage()
         $this->assertRegExp('/media\/pages\/test\/.*-.*\/test.jpeg/', $response->body());
     }
 
-//    public function testFindsRoute()
-//    {
-//        $response = kirby()->response('de/path/test');
-//        $this->assertTrue($response->code() === 200);
-//        $this->assertTrue('application/json' === $response->type());
-//    }
+    public function testFindsRouteFromTestConfig()
+    {
+        $response = kirby()->render('en/path/pages/test');
+        $this->assertTrue($response->code() === 200);
+        $this->assertTrue('application/json' === $response->type());
+        $this->assertStringContainsString(
+            'pages/test',
+            json_decode($response->body())->path
+        );
+    }
 }

tests/site/blueprints/pages/default.yml

@@ -8,4 +8,4 @@ sections:
     type: fields
     fields:
       testimage:
-        type: image
+        type: files

tests/site/config/config.php

@@ -18,8 +18,8 @@
             [
                 'pattern' => 'path/(:all)',
                 'method' => 'GET',
-                'language' => '*',
-                'action' => function (string $path = null) {
+                'language' => 'en',
+                'action' => function ($language, string $path = null) {
                     return ['path' => $path];
                 },
             ],