Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added onShowing, onShown, onClosing, onClosed prop events #13

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

murat-mehmet
Copy link

These events may be used in ui modifications while showing and hiding the notification.

These events may be used in ui modifications while showing and hiding the notification.
added onShowing, onShown, onClosing, onClosed to README
onClosed will be fired with a parameter that informs if notification is being closed just to show again,
in my case, I was hiding notification in onClosed event, but in case that it will be shown again, it should not be removed.
Notification.js Outdated Show resolved Hide resolved
Notification.js Outdated Show resolved Hide resolved
Copy link
Owner

@robcalcroft robcalcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@YamadaTakahito
Copy link

@murat-mehmet
Thank you for your modification.
I want to use this future, too.
If you have time, would you fix conflict?

@robcalcroft
Copy link
Owner

@murat-mehmet if you can resolve the conflicts I can merge

@YamadaTakahito
Copy link

@robcalcroft
OK 😄
I submited fixed pull request (#47).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants