Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build hook for garage-base docker image #2257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gitanshu
Copy link
Contributor

@gitanshu gitanshu commented Mar 19, 2021

This image can then be used as the parent image for metaworld-ci docker image, instead of garage-headless as of now, which we discontinued in end of Jan 2021.

@gitanshu gitanshu requested a review from a team as a code owner March 19, 2021 22:16
@gitanshu gitanshu requested review from ryanjulian and removed request for a team March 19, 2021 22:16
@mergify mergify bot requested review from a team, yeukfu and ziyiwu9494 and removed request for a team March 19, 2021 22:17
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #2257 (cdf5d4b) into master (1e7ca02) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
+ Coverage   91.25%   91.28%   +0.02%     
==========================================
  Files         199      199              
  Lines       11761    10966     -795     
  Branches     1583     1387     -196     
==========================================
- Hits        10733    10010     -723     
+ Misses        758      694      -64     
+ Partials      270      262       -8     
Impacted Files Coverage Δ
src/garage/torch/optimizers/optimizer_wrapper.py 93.75% <0.00%> (-6.25%) ⬇️
src/garage/sampler/env_update.py 82.92% <0.00%> (-3.62%) ⬇️
src/garage/torch/optimizers/differentiable_sgd.py 86.66% <0.00%> (-3.34%) ⬇️
src/garage/torch/policies/stochastic_policy.py 88.63% <0.00%> (-3.17%) ⬇️
src/garage/torch/algos/trpo.py 91.66% <0.00%> (-3.08%) ⬇️
src/garage/torch/algos/dqn.py 93.07% <0.00%> (-2.09%) ⬇️
src/garage/torch/_functions.py 92.42% <0.00%> (-1.92%) ⬇️
src/garage/torch/algos/sac.py 97.14% <0.00%> (-1.66%) ⬇️
src/garage/torch/modules/gaussian_mlp_module.py 92.13% <0.00%> (-1.52%) ⬇️
src/garage/sampler/multiprocessing_sampler.py 90.12% <0.00%> (-1.24%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7ca02...cdf5d4b. Read the comment docs.

@mergify mergify bot requested a review from a team March 31, 2021 20:26
@gitanshu gitanshu force-pushed the publish-garage-base-docker branch from affa46f to 0bedead Compare May 7, 2021 22:31
@gitanshu gitanshu force-pushed the publish-garage-base-docker branch from 0bedead to cdf5d4b Compare May 11, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants