-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add nx to monorepo #2984
Conversation
@ahkhanjani It looks like you'll need to make some changes to fix the build |
Seems like for some reason npm messed up the lock-files. I'll make another commit |
@ahkhanjani A previous commit is actually breaking the build. I am about to merge a PR with the fix for it. You may have to wait a few hours and do a rebase. |
from package.json to .prettierrc.yaml
Thanks for telling. I will try to fix some issues on my side as well. Please consider reading this document for the free cloud caching by Nx. This is going to be added with this PR being merged and will speed up the build process. |
@ahkhanjani did you want to join our weekly meeting on August 5th at 11am Eastern Time (see #2417 for details) to walk us through your PR and where you see things going? |
I'm afraid my time zone doesn't let me. But I can provide a written documentation and milestone. |
"build:dist", | ||
"publish-to-gh-pages" | ||
], | ||
"accessToken": "N2UzOTU5MGQtMmM1OS00MTM2LWJjM2QtZDZhM2IxOWYzM2RkfHJlYWQtd3JpdGU=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a secret that needs to be passed in as a variable? I'm not sure we want to use the cloud... and if we did, we really don't want this secret sitting in a public file (we have a place for them). Can we not use the cloud services by default?
That would be great! |
@ahkhanjani Looks like you have conflicts... Rebase onto the latest and when you resolve the |
I will create a new pr as the current rebase ended up in a mess. |
The first step of transitioning from Lerna to Nx. This currently doesn't have a breaking effect. To use Nx tools in vscode install "Nx Console" extension.