Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed menu letter-casing to 'sentence-style' capitalization #3381

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Changed menu letter-casing to 'sentence-style' capitalization #3381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 42 additions & 41 deletions src/core/MainWindow.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
<widget class="QMenu" name="menuFile">
<property name="geometry">
<rect>
<x>2024</x>
<y>127</y>
<width>151</width>
<height>312</height>
<x>339</x>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

<y>101</y>
<width>187</width>
<height>399</height>
</rect>
</property>
<property name="title">
Expand Down Expand Up @@ -201,7 +201,7 @@
</sizepolicy>
</property>
<property name="contextMenuPolicy">
<enum>Qt::DefaultContextMenu</enum>
<enum>Qt::ContextMenuPolicy::DefaultContextMenu</enum>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrelevant change?

</property>
<property name="windowTitle">
<string notr="true">Main toolbar</string>
Expand All @@ -216,7 +216,7 @@
</size>
</property>
<property name="toolButtonStyle">
<enum>Qt::ToolButtonIconOnly</enum>
<enum>Qt::ToolButtonStyle::ToolButtonIconOnly</enum>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

</property>
<attribute name="toolBarArea">
<enum>TopToolBarArea</enum>
Expand Down Expand Up @@ -257,7 +257,7 @@
</action>
<action name="actionNew">
<property name="text">
<string>New Window</string>
<string>New window</string>
</property>
<property name="shortcut">
<string>Ctrl+N</string>
Expand All @@ -283,15 +283,15 @@
</action>
<action name="actionMap">
<property name="text">
<string>Map File</string>
<string>Map file</string>
</property>
<property name="shortcut">
<string>Ctrl+M</string>
</property>
</action>
<action name="actionSave">
<property name="text">
<string>Save Project</string>
<string>Save project</string>
</property>
<property name="shortcut">
<string>Ctrl+S</string>
Expand Down Expand Up @@ -348,23 +348,23 @@
</action>
<action name="actionBackward">
<property name="icon">
<iconset>
<iconset resource="../resources.qrc">
<normaloff>:/img/icons/arrow_left.svg</normaloff>:/img/icons/arrow_left.svg</iconset>
</property>
<property name="text">
<string>Undo Seek</string>
<string>Undo seek</string>
</property>
<property name="toolTip">
<string>Go back</string>
</property>
</action>
<action name="actionForward">
<property name="icon">
<iconset>
<iconset resource="../resources.qrc">
<normaloff>:/img/icons/arrow_right.svg</normaloff>:/img/icons/arrow_right.svg</iconset>
</property>
<property name="text">
<string>Redo Seek</string>
<string>Redo seek</string>
</property>
</action>
<action name="actionUnlock">
Expand All @@ -374,16 +374,17 @@
<property name="checked">
<bool>true</bool>
</property>
<property name="icon">
<iconset resource="../resources.qrc">
<normaloff>:/lock</normaloff>
<normalon>:/unlock</normalon>:/lock</iconset>
</property>
<property name="text">
<string>Unlock Panels</string>
<string>Unlock panels</string>
</property>
<property name="toolTip">
<string>Toggle panel locks</string>
</property>
<property name="icon">
<iconset>
<normaloff>:/lock</normaloff><normalon>:/unlock</normalon>:/unlock</iconset>
</property>
<property name="iconVisibleInMenu">
<bool>false</bool>
</property>
Expand All @@ -393,7 +394,7 @@
<bool>false</bool>
</property>
<property name="icon">
<iconset>
<iconset resource="../resources.qrc">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

<normaloff>:/img/icons/themes.svg</normaloff>:/img/icons/themes.svg</iconset>
</property>
<property name="text">
Expand All @@ -403,12 +404,12 @@
<bool>false</bool>
</property>
<property name="menuRole">
<enum>QAction::PreferencesRole</enum>
<enum>QAction::MenuRole::PreferencesRole</enum>
</property>
</action>
<action name="actionTabs">
<property name="icon">
<iconset>
<iconset resource="../resources.qrc">
<normaloff>:/img/icons/tabs.svg</normaloff>:/img/icons/tabs.svg</iconset>
</property>
<property name="text">
Expand All @@ -420,7 +421,7 @@
</action>
<action name="actionRefresh_Panels">
<property name="icon">
<iconset>
<iconset resource="../resources.qrc">
<normaloff>:/img/icons/spin.svg</normaloff>:/img/icons/spin.svg</iconset>
</property>
<property name="text">
Expand All @@ -432,7 +433,7 @@
<bool>true</bool>
</property>
<property name="text">
<string>Show Tabs at the Top</string>
<string>Show tabs at the top</string>
</property>
<property name="toolTip">
<string>Toggle tab position</string>
Expand Down Expand Up @@ -565,7 +566,7 @@
<bool>true</bool>
</property>
<property name="icon">
<iconset>
<iconset resource="../resources.qrc">
<normaloff>:/img/icons/cloud.svg</normaloff>:/img/icons/cloud.svg</iconset>
</property>
<property name="text">
Expand Down Expand Up @@ -645,7 +646,7 @@
<bool>true</bool>
</property>
<property name="icon">
<iconset>
<iconset resource="../resources.qrc">
<normaloff>:/img/icons/down.svg</normaloff>:/img/icons/down.svg</iconset>
</property>
<property name="text">
Expand All @@ -662,7 +663,7 @@
</action>
<action name="actionReset_settings">
<property name="text">
<string>Reset Settings</string>
<string>Reset settings</string>
</property>
<property name="toolTip">
<string>Reset settings</string>
Expand All @@ -689,7 +690,7 @@
</action>
<action name="actionRefresh_contents">
<property name="text">
<string>Refresh Contents</string>
<string>Refresh contents</string>
</property>
<property name="toolTip">
<string>Refresh contents</string>
Expand Down Expand Up @@ -729,7 +730,7 @@
</action>
<action name="actionSaveAs">
<property name="text">
<string>Save Project As...</string>
<string>Save project as...</string>
</property>
</action>
<action name="actionGraph">
Expand All @@ -747,7 +748,7 @@
</action>
<action name="actionAnalyze">
<property name="text">
<string>Analyze Program</string>
<string>Analyze program</string>
</property>
</action>
<action name="actionExport_as_code">
Expand All @@ -757,32 +758,32 @@
</action>
<action name="actionApplySigFromFile">
<property name="text">
<string>Apply Signature From File</string>
<string>Apply signature from file</string>
</property>
</action>
<action name="actionCreateNewSig">
<property name="text">
<string>Create New Signature File</string>
<string>Create new signature file</string>
</property>
</action>
<action name="actionExtraHexdump">
<property name="text">
<string>Add Hexdump</string>
<string>Add hexdump</string>
</property>
</action>
<action name="actionExtraDecompiler">
<property name="text">
<string>Add Decompiler</string>
<string>Add decompiler</string>
</property>
</action>
<action name="actionExtraDisassembly">
<property name="text">
<string>Add Disassembly</string>
<string>Add disassembly</string>
</property>
</action>
<action name="actionExtraGraph">
<property name="text">
<string>Add Graph</string>
<string>Add graph</string>
</property>
</action>
<action name="actionGrouped_dock_dragging">
Expand All @@ -798,24 +799,24 @@
</action>
<action name="actionZoomIn">
<property name="text">
<string>Zoom In</string>
<string>Zoom in</string>
</property>
<property name="shortcut">
<string>Ctrl++</string>
</property>
<property name="shortcutContext">
<enum>Qt::ApplicationShortcut</enum>
<enum>Qt::ShortcutContext::ApplicationShortcut</enum>
</property>
</action>
<action name="actionZoomOut">
<property name="text">
<string>Zoom Out</string>
<string>Zoom out</string>
</property>
<property name="shortcut">
<string>Ctrl+-</string>
</property>
<property name="shortcutContext">
<enum>Qt::ApplicationShortcut</enum>
<enum>Qt::ShortcutContext::ApplicationShortcut</enum>
</property>
</action>
<action name="actionZoomReset">
Expand All @@ -826,7 +827,7 @@
<string>Ctrl+=</string>
</property>
<property name="shortcutContext">
<enum>Qt::ApplicationShortcut</enum>
<enum>Qt::ShortcutContext::ApplicationShortcut</enum>
</property>
</action>
<action name="actionCommitChanges">
Expand Down Expand Up @@ -880,7 +881,7 @@
</widget>
<layoutdefault spacing="6" margin="11"/>
<resources>
<include location="resources.qrc"/>
<include location="../resources.qrc"/>
</resources>
<connections/>
</ui>
6 changes: 3 additions & 3 deletions src/menus/DecompilerContextMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ DecompilerContextMenu::DecompilerContextMenu(QWidget *parent, MainWindow *mainWi
actionCopyInstructionAddress(tr("Copy instruction address (<address>)"), this),
actionCopyReferenceAddress(tr("Copy address of [flag] (<address>)"), this),
actionShowInSubmenu(tr("Show in"), this),
actionAddComment(tr("Add Comment"), this),
actionAddComment(tr("Add comment"), this),
actionDeleteComment(tr("Delete comment"), this),
actionRenameThingHere(tr("Rename function at cursor"), this),
actionDeleteName(tr("Delete <name>"), this),
Expand Down Expand Up @@ -163,10 +163,10 @@ void DecompilerContextMenu::aboutToShowSlot()
actionAddComment.setVisible(true);
if (comment.isEmpty()) {
actionDeleteComment.setVisible(false);
actionAddComment.setText(tr("Add Comment"));
actionAddComment.setText(tr("Add comment"));
} else {
actionDeleteComment.setVisible(true);
actionAddComment.setText(tr("Edit Comment"));
actionAddComment.setText(tr("Edit comment"));
}
} else {
actionShowInSubmenu.setVisible(false);
Expand Down
Loading
Loading