Added option to add new flags from hexdump #2932

.vscode/settings.json

@@ -1,3 +1,79 @@
 {
-    "cmake.sourceDirectory": "${workspaceFolder}"
+    "cmake.sourceDirectory": "${workspaceFolder}",
+    "files.associations": {
+        "typeinfo": "cpp",
+        "__bit_reference": "cpp",
+        "__config": "cpp",
+        "__debug": "cpp",
+        "__errc": "cpp",
+        "__functional_base": "cpp",
+        "__hash_table": "cpp",
+        "__locale": "cpp",
+        "__mutex_base": "cpp",
+        "__node_handle": "cpp",
+        "__nullptr": "cpp",
+        "__split_buffer": "cpp",
+        "__string": "cpp",
+        "__threading_support": "cpp",
+        "__tree": "cpp",
+        "__tuple": "cpp",
+        "algorithm": "cpp",
+        "array": "cpp",
+        "atomic": "cpp",
+        "bit": "cpp",
+        "bitset": "cpp",
+        "cctype": "cpp",
+        "chrono": "cpp",
+        "cmath": "cpp",
+        "compare": "cpp",
+        "complex": "cpp",
+        "cstdarg": "cpp",
+        "cstddef": "cpp",
+        "cstdint": "cpp",
+        "cstdio": "cpp",
+        "cstdlib": "cpp",
+        "cstring": "cpp",
+        "ctime": "cpp",
+        "cwchar": "cpp",
+        "cwctype": "cpp",
+        "deque": "cpp",
+        "exception": "cpp",
+        "functional": "cpp",
+        "future": "cpp",
+        "initializer_list": "cpp",
+        "iomanip": "cpp",
+        "ios": "cpp",
+        "iosfwd": "cpp",
+        "iostream": "cpp",
+        "istream": "cpp",
+        "iterator": "cpp",
+        "limits": "cpp",
+        "list": "cpp",
+        "locale": "cpp",
+        "map": "cpp",
+        "memory": "cpp",
+        "mutex": "cpp",
+        "new": "cpp",
+        "numeric": "cpp",
+        "optional": "cpp",
+        "ostream": "cpp",
+        "queue": "cpp",
+        "random": "cpp",
+        "ratio": "cpp",
+        "set": "cpp",
+        "sstream": "cpp",
+        "stack": "cpp",
+        "stdexcept": "cpp",
+        "streambuf": "cpp",
+        "string": "cpp",
+        "string_view": "cpp",
+        "system_error": "cpp",
+        "tuple": "cpp",
+        "type_traits": "cpp",
+        "unordered_map": "cpp",
+        "unordered_set": "cpp",
+        "utility": "cpp",
+        "variant": "cpp",
+        "vector": "cpp"
+    }
 }

docs/source/user-docs/menus/hexdump-widget-context-menu.rst

@@ -17,4 +17,18 @@ Available options are:
  - 8 bytes
  - 16 bytes
  - 32 bytes
- - Power of 2 (Auto)
+ - Power of 2 (Auto)
+
+Add Flag
+----------------------------------------
+**Description:** Add a flag to the selected item or location by bookmarking and giving it a name. 
+
+**Steps:** Right-click an address or item and choose ``Add Flag``  
+
+**Shortcut:** :kbd:`N`  
+
+Delete Flag
+----------------------------------------
+**Description:** Delete a flag from the selected item or location. 
+
+**Steps:** Right-click an address or item and choose ``Delete Flag`` 

src/dialogs/CommentsDialog.cpp

@@ -1,6 +1,5 @@
 #include "CommentsDialog.h"
 #include "ui_CommentsDialog.h"
-
 #include <QErrorMessage>
 
 #include "core/Cutter.h"

src/dialogs/FlagDialog.cpp

@@ -1,6 +1,5 @@
 #include "FlagDialog.h"
 #include "ui_FlagDialog.h"
-
 #include <QIntValidator>
 #include "core/Cutter.h"
 

src/menus/DisassemblyContextMenu.cpp

@@ -11,7 +11,6 @@
 #include "dialogs/EditStringDialog.h"
 #include "dialogs/BreakpointsDialog.h"
 #include "MainWindow.h"
-
 #include <QtCore>
 #include <QShortcut>
 #include <QJsonArray>

src/widgets/HexWidget.cpp

@@ -3,7 +3,7 @@
 #include "Configuration.h"
 #include "dialogs/WriteCommandsDialogs.h"
 #include "dialogs/CommentsDialog.h"
-
+#include "dialogs/FlagDialog.h"
 #include <QPainter>
 #include <QPaintEvent>
 #include <QResizeEvent>
@@ -50,7 +50,6 @@ HexWidget::HexWidget(QWidget *parent)
     setFocusPolicy(Qt::FocusPolicy::StrongFocus);
     connect(horizontalScrollBar(), &QScrollBar::valueChanged, this,
             [this]() { viewport()->update(); });
-
     connect(Config(), &Configuration::colorsUpdated, this, &HexWidget::updateColors);
     connect(Config(), &Configuration::fontsUpdated, this,
             [this]() { setMonospaceFont(Config()->getFont()); });
@@ -137,6 +136,19 @@ HexWidget::HexWidget(QWidget *parent)
             &HexWidget::onActionDeleteCommentTriggered);
     addAction(actionDeleteComment);
 
+    // Add flag option
+    actionFlag = new QAction(tr("Add Flag"), this);
+    actionFlag->setShortcutContext(Qt::ShortcutContext::WidgetWithChildrenShortcut);
+    actionFlag->setShortcut(Qt::Key_N);
+    connect(actionFlag, &QAction::triggered, this, &HexWidget::onActionAddFlagTriggered);
+    addAction(actionFlag);
+
+    // Delete flag option
+    actionDeleteFlag = new QAction(tr("Delete Flag"), this);
+    actionDeleteFlag->setShortcutContext(Qt::ShortcutContext::WidgetWithChildrenShortcut);
+    connect(actionDeleteFlag, &QAction::triggered, this, &HexWidget::onActionDeleteFlagTriggered);
+    addAction(actionDeleteFlag);
+
     actionSelectRange = new QAction(tr("Select range"), this);
     connect(actionSelectRange, &QAction::triggered, this,
             [this]() { rangeDialog.open(cursor.address); });
@@ -214,6 +226,11 @@ HexWidget::HexWidget(QWidget *parent)
     connect(&warningTimer, &QTimer::timeout, this, &HexWidget::hideWarningRect);
 }
 
+QWidget *HexWidget::parentForDialog()
+{
+    return parentWidget();
+}
+
 void HexWidget::setMonospaceFont(const QFont &font)
 {
     if (!(font.styleHint() & QFont::Monospace)) {
@@ -1160,6 +1177,17 @@ void HexWidget::contextMenuEvent(QContextMenuEvent *event)
         actionComment->setText(tr("Edit Comment"));
     }
 
+    QString flag = Core()->flagAt(cursor.address);
+    RzFlagItem *flagItem = rz_flag_get_i(Core()->core()->flags, cursor.address);
+
+    if (flagItem == 0x0 || flag.isNull() || flag.isEmpty()) {
+        actionDeleteFlag->setVisible(false);
+        actionFlag->setText(tr("Add Flag"));
+    } else {
+        actionDeleteFlag->setVisible(true);
+        actionFlag->setText(tr("Edit Flag"));
+    }
+
     if (!ioModesController.canWrite()) {
         actionKeyboardEdit->setChecked(false);
     }
@@ -1233,6 +1261,21 @@ void HexWidget::onActionAddCommentTriggered()
     CommentsDialog::addOrEditComment(addr, this);
 }
 
+// slog for add flag action
+void HexWidget::onActionAddFlagTriggered()
+{
+    uint64_t addr = cursor.address;
+    FlagDialog dialog(addr, this);
+    dialog.exec();
+}
+
+// slot for deleting flag action
+void HexWidget::onActionDeleteFlagTriggered()
+{
+    uint64_t addr = cursor.address;
+    Core()->delFlag(addr);
+}
+
 // slot for deleting comment action
 void HexWidget::onActionDeleteCommentTriggered()
 {

src/widgets/HexWidget.h

@@ -382,6 +382,8 @@ private slots:
     void copyAddress();
     void onRangeDialogAccepted();
     void onActionAddCommentTriggered();
+    void onActionAddFlagTriggered();
+    void onActionDeleteFlagTriggered();
     void onActionDeleteCommentTriggered();
 
     // Write command slots
@@ -424,6 +426,7 @@ private slots:
     QString renderItem(int offset, QColor *color = nullptr);
     QChar renderAscii(int offset, QColor *color = nullptr);
     QString getFlagsAndComment(uint64_t address);
+    QWidget *parentForDialog();
     /**
      * @brief Get the location on which operations such as Writing should apply.
      * @return Start of selection if multiple bytes are selected. Otherwise, the curren seek of the
@@ -576,6 +579,8 @@ private slots:
     QAction *actionCopy;
     QAction *actionCopyAddress;
     QAction *actionComment;
+    QAction *actionFlag;
+    QAction *actionDeleteFlag;
     QAction *actionDeleteComment;
     QAction *actionSelectRange;
     QAction *actionKeyboardEdit;

src/widgets/HexdumpWidget.h

@@ -34,6 +34,7 @@ class HexdumpWidget : public MemoryDockWidget
     Highlighter *highlighter;
 
     static QString getWidgetType();
+    QWidget *parentForDialog();
 
 public slots:
     void initParsing();