Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate entries in recent projects #2644

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Prevent duplicate entries in recent projects #2644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/common/Configuration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,5 +791,8 @@ void Configuration::addRecentProject(QString file)
QStringList files = getRecentProjects();
files.removeAll(file);
files.prepend(file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, this should prevent duplicates from appearing at all in the list. Do you know in which case a duplicate actually gets added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't actually remember. I didn't do anything special. I reported it to you and forgot to open an issue, so few weeks later I just sent a PR :)
It happened on windows

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be related to case-sensitivity then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so? and how the snippet you share is taking care of duplicate entries?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before adding any file to the list it does files.removeAll(file); to remove all previous occurences of it.
On Windows, paths are not case sensitive, so if you add a path with different upper/lowercase, it might still refer to the same file but the string is different.


// Make sure we don't keep duplicate entries
files.removeDuplicates();
setRecentProjects(files);
}