feat: Bind modules/<dep_name>/public.ts to Module.<depName>
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Blckbrry-Pi and the rest of your teammates on |
Blckbrry-Pi
changed the title
modules/<depname>/public.ts to Public.<depname>modules/<depname>/public.ts to Public.<depname>
Blckbrry-Pi
force-pushed
the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
4 times, most recently
from
a6b4195
to
10e6653
Compare
Blckbrry-Pi
changed the title
modules/<depname>/public.ts to Public.<depname>modules/<dep_name>/public.ts to Module.<depName>
Base automatically changed from
04-17-fix_issue_with_adaptername_conflict_in_generated_prisma_schemas
to
main
May 1, 2024 19:50
Blckbrry-Pi
force-pushed
the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
from
10e6653
to
b01d7fe
Compare
MasterPtato
approved these changes
May 2, 2024
NathanFlurry
requested changes
May 15, 2024
src/build/gen/mod.ts
Outdated
| else return formatPath({ ...parsed, dir: `.` }); | ||
| } | ||
|
|
||
| export class GeneratedFile { |
There was a problem hiding this comment.
nit: move to separate file
nit: rename to something like GeneratedCodeBuilder or something with "Builder" in the name
needs docs on what this class does
cool helper though
There was a problem hiding this comment.
Moved and renamed, will add jsdoc comments
Blckbrry-Pi
force-pushed
the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
2 times, most recently
from
b20acf1
to
c1a64ac
Compare
Blckbrry-Pi
changed the base branch from
main
to
05-15-refactor_rewrite_buildregistryproxy_and_comment_src_runtime_proxy.ts_to_make_it_more_understandable_by_maintainers_and_contributors
Blckbrry-Pi
force-pushed
the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
from
c1a64ac
to
75141cc
Compare
Blckbrry-Pi
changed the base branch from
05-15-refactor_rewrite_buildregistryproxy_and_comment_src_runtime_proxy.ts_to_make_it_more_understandable_by_maintainers_and_contributors
to
05-17-refactor_rewrite_all_codegen_using_the_new_generatedcodebuilder_class_move_everything_to_._src_build_gen_
Blckbrry-Pi
force-pushed
the
05-17-refactor_rewrite_all_codegen_using_the_new_generatedcodebuilder_class_move_everything_to_._src_build_gen_
branch
from
3dc84d3
to
f641967
Compare
Blckbrry-Pi
force-pushed
the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
2 times, most recently
from
92767b2
to
e88d846
Compare
NathanFlurry
approved these changes
May 18, 2024
NathanFlurry
force-pushed
the
05-17-refactor_rewrite_all_codegen_using_the_new_generatedcodebuilder_class_move_everything_to_._src_build_gen_
branch
from
f641967
to
a360312
Compare
NathanFlurry
force-pushed
the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
from
e88d846
to
a25b912
Compare
Merge activity
|
NathanFlurry
force-pushed
the
05-17-refactor_rewrite_all_codegen_using_the_new_generatedcodebuilder_class_move_everything_to_._src_build_gen_
branch
from
a360312
to
69a5619
Compare
Base automatically changed from
05-17-refactor_rewrite_all_codegen_using_the_new_generatedcodebuilder_class_move_everything_to_._src_build_gen_
to
main
May 18, 2024 21:03
NathanFlurry
force-pushed
the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
from
a25b912
to
44b0347
Compare
NathanFlurry
deleted the
04-24-bind_modules__depname__public.ts_to_public._depname_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.