-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows viewer #339
base: master
Are you sure you want to change the base?
Windows viewer #339
Conversation
826d8ae
to
5cb6f0b
Compare
Oh this new gmtime stuff is throwing windows as gmtime_r isn't availbale there. I'm going to ifdef this out as it should be experimental anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try running this locally on my windows box
# Conflicts: # .gitignore # skia/viewer/src/main.cpp
# Conflicts: # dev/test/premake5.lua
4abb84f
to
3bc2358
Compare
I'd like to land this so the Noesis team can keep using it. It's not an ideal build system design but it does unblock an important initiative. |
thanks @luigi-rosso |
I build it on Windows in our RiveQtQuickPlugin. Since Qt uses cmake, I basically just created simple cmakelists files out of source and avoid using premake5. With that I can build it with visual studio compiler, gcc (with a small patch), clang,... Just take a look at the repo. |
Thanks @jebos |
Exploring what support for a Windows viewer would look like.
Currently required creating a separate build folder for Windows with its own Premake. I've done a better job in other projects (like rive-unity) of maintaining one premake5.lua for all environments. Our current one in this repo is just a little too funky to patch for this (we import multiple premake scripts and they each sort of do their own thing to try to be OS-agnostic, but none of them really do it well).
Only real code change is the need to supply "b" to fopen on Windows. The rest of it is config and dependency retrieval/building.
Readme with requirements here: https://github.com/rive-app/rive-cpp/tree/windows_viewer/skia/viewer/build/windows