feat: message_as_jsonb to handle circle dep in protobuf (#19935)
#19992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tabversion <[email protected]>
|
resolve #19986 |
9 tasks
lmatz
approved these changes
Jan 2, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -91,10 +104,12 @@ fn detect_loop_and_push( | |||
| let identifier = format!("{}({})", fd.name(), fd.full_name()); | |||
| if trace.iter().any(|s| s == identifier.as_str()) { | |||
| bail_protobuf_type_error!( | |||
| "circular reference detected: {}, conflict with {}, kind {:?}", | |||
| "circular reference detected: {}, conflict with {}, kind {:?}. Adding {:?} to {:?} may help.", | |||
There was a problem hiding this comment.
The error message suggests adding fd.kind() to messages_as_jsonb, but this is incorrect since messages_as_jsonb expects full message type names. The message should suggest adding fd.descriptor().full_name() instead to properly guide users on how to resolve circular reference errors.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
For a proto message, printing kind equals the full name.
xiangjinwu
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note