Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: feat(storage): non_pk_watermark state clean #19889

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

WIP: feat(storage): non_pk_watermark state clean #19889

wants to merge 12 commits into from
+1,081 −222

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Dec 23, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

related to #18802

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k changed the title feat(storage): non_pk_watermark state clean WIP: feat(storage): non_pk_watermark state clean Dec 23, 2024
@Li0k Li0k marked this pull request as ready for review December 23, 2024 07:28
@graphite-app graphite-app bot requested a review from a team December 23, 2024 08:18
@Li0k Li0k requested a review from a team as a code owner December 25, 2024 12:20
@Li0k Li0k requested a review from xxchan December 25, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan Awaiting requested review from xxchan xxchan is a code owner automatically assigned from risingwavelabs/cargo-lock

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends Invalid PR Title type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Li0k