Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): support metadata tables #19873

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

support table functions iceberg_xxx, e.g.,

select * from iceberg_snapshots(iceberg_source);

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Ok(Box::new(IcebergMetadataScanExecutor {
iceberg_properties,
identity: source.plan_node().get_identity().clone(),
schema: Schema::new(vec![]),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema should be initialized using iceberg_metadata_table_schema(node.table_type) rather than Schema::new(vec![]) to properly reflect the metadata table's structure. The current empty schema means no columns would be available, which is incorrect.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant