Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LabelsBundle_es_ES.properties #111

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

lbalmaceda
Copy link

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Hi team -
I took the en_us file and checked for entries that were not defined in the es_es file. I added those and added their spanish translations. I've also updated some of the old ones.

Also added retry.sleep.mill that is not available in the "ripmeapp/ripme" repo.

Relates to: RipMeApp#2004

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@soloturn soloturn merged commit dffcb4f into ripmeapp2:main Oct 9, 2022
@lbalmaceda
Copy link
Author

@soloturn thanks for the quick merge! Would you be able to add the hacktoberfest-approved label to this PR, please, so it counts towards my goal? Cheers

@lbalmaceda lbalmaceda deleted the patch-2 branch October 10, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants