-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e github actions #6303
Open
himadrisingh
wants to merge
31
commits into
cloud-e2e-setup-services
Choose a base branch
from
e2e-gha
base: cloud-e2e-setup-services
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
e2e github actions #6303
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
782f595
e2e github actions
himadrisingh f7c6cc5
Update web-test-e2e.yml
himadrisingh de0b285
Update web-test-e2e.yml
himadrisingh 2874c98
Update web-test-e2e.yml
himadrisingh 0949768
Update web-test-e2e.yml
himadrisingh 22c87ec
Update web-test-e2e.yml
himadrisingh e965629
Update web-test-e2e.yml
himadrisingh 044e0fb
Update web-test-e2e.yml
himadrisingh ef693d6
Update web-test-e2e.yml
himadrisingh fe9f1d5
Update web-test-e2e.yml
himadrisingh 934cfe7
Update web-test-e2e.yml
himadrisingh d9f07a8
Update web-test-e2e.yml
himadrisingh 44bf655
Update web-test-e2e.yml
himadrisingh e7d6ac7
Update web-test-e2e.yml
himadrisingh 0076985
Update web-test-e2e.yml
himadrisingh 024b55a
Update web-test-e2e.yml
himadrisingh 456ed4b
Update web-test-e2e.yml
himadrisingh 89c93aa
Update web-test-e2e.yml
himadrisingh 7217dbd
Update web-test-e2e.yml
himadrisingh d80b84e
Update web-test-e2e.yml
himadrisingh cfab268
Update web-test-e2e.yml
himadrisingh 014797f
Update web-test-e2e.yml
himadrisingh 69ac430
Update web-test-e2e.yml
himadrisingh 8728a69
Update web-test-e2e.yml
himadrisingh f024e55
Update web-test-e2e.yml
himadrisingh 0c15930
Update web-test-e2e.yml
himadrisingh ebfaacf
Update web-test-e2e.yml
himadrisingh 0eec4dd
de bug
himadrisingh 5df64e0
Update web-test-e2e.yml
himadrisingh f63fb07
Update .github/workflows/web-test-e2e.yml
himadrisingh 5cc631d
Revert "Update .github/workflows/web-test-e2e.yml"
himadrisingh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like these environment variables are adding an extra layer of indirection. Could we use
filter.outputs
directly in thejq
command like:select(${{ steps.filter.outputs.admin }} == "true" or ${{ steps.filter.outputs.common }} == "true")
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further, can we treat the filter output like a typical boolean, not a string, like:
select(${{ steps.filter.outputs.admin }} or ${{ steps.filter.outputs.common }})
or even without the
select
function:if ${{ steps.filter.outputs.admin }} or ${{ steps.filter.outputs.common }} then "web-admin" else empty end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it doesn't have access to
steps.filter.outputs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? This example seems to show it's possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tried f63fb07 but it didnt work out. probably its jq or single quote.