This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Named reference types #192
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactorized
pushed a commit
to refactorized/sanity-codegen
that referenced
this pull request
Dec 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass effort at addressing #191. This solution involves treating top-level (no parents) references differently. I have tested this and found its output consistent with the structure sanity returns.
I have not written tests yet, as I imagine we would want to maybe clean up the formatting of the output. Also generics are not created for each type in the
toarray like normal references. I am not sure what the best way to accomplish that is.