Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add username and password auth method #203

Merged
merged 3 commits into from
Oct 15, 2023
Merged

add username and password auth method #203

merged 3 commits into from
Oct 15, 2023

Conversation

PatrickKoss
Copy link
Contributor

Hey :)

I like this project and used it happily in the past. Now I have to use a secrets manager (vault) that currently only support username and password auth. Therefore I think it will be useful (at least for me) to add the userpass auth method.

Best regards,
Patrick

@ricoberger
Copy link
Owner

Hi @PatrickKoss thanks for your contribution 🙂.

Does it make sense to add a new test in https://github.com/ricoberger/vault-secrets-operator/tree/main/hack similar to the other authentication methods?

@ricoberger ricoberger added the changelog: added A new feature was added label Oct 15, 2023
@PatrickKoss
Copy link
Contributor Author

Yes @ricoberger it of course makes sense. I was just not aware of the tests :D Added one for username and password. Can you have a look again?

@ricoberger
Copy link
Owner

Awesome work @PatrickKoss and thanks for adding the test.

I think there is only a problem with the file permissions for the added test, which should be fixed by running chmod +x hack/setup-kind-userpass.sh, everything else is looking good.

@PatrickKoss
Copy link
Contributor Author

PatrickKoss commented Oct 15, 2023

@ricoberger executed the command, so hopefully should work now

@ricoberger
Copy link
Owner

Thank you 🙂

@ricoberger ricoberger merged commit 5c9210e into ricoberger:main Oct 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: added A new feature was added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants