Updated README steps, docker scripts and fixed bc error #9
Conversation
jordantrizz
commented
Oct 24, 2024
jordantrizz
commented
- Update README.md
- Update build.sh
- Updated to build container so that run.sh works.
- Update Dockerfile
- Added bc to required files due to error when starting container.
- Updated docker scripts and created docker-compose.yml
- Added docker-compose.override.yml to .gitignore
- Updated docker-compose.yml file to use github repository for build versus local.
|
The command bc was added to the docker image due to #10 |
|
I've also added the url to the updated instructions for nvidia container toolkit mentioned in issue #7 |
|
I updated the docker scripts, and added in a docker-compose.yml that references this github repository versus the local docker build directory. This should be replaced with a release branch, versus using main. Also added instructions for development with docker-compose.override.yml |
README.md
Outdated
| curl -fsSL https://nvidia.github.io/libnvidia-container/gpgkey | sudo gpg --dearmor -o /usr/share/keyrings/nvidia-container-toolkit-keyring.gpg \ | ||
| && curl -s -L https://nvidia.github.io/libnvidia-container/stable/deb/nvidia-container-toolkit.list | \ | ||
| sed 's#deb https://#deb [signed-by=/usr/share/keyrings/nvidia-container-toolkit-keyring.gpg] https://#g' | \ | ||
| sudo tee /etc/apt/sources.list.d/nvidia-container-toolkit.list | ||
| ``` | ||
| sudo tee /etc/apt/sources.list.d/nvidia-container-toolkit.list4 |
There was a problem hiding this comment.
I don't see the changes to the README reflected in the install.ps1 script - please keep them the same.
I think the nvidia-container-toolkit.list4 file is probably still nvidia-container-toolkit.list? I dont see any info about such change in the linked documentation.
There was a problem hiding this comment.
Fixed the list4 as it looks to be a typo.
There was a problem hiding this comment.
I don't see the changes to the README reflected in the
install.ps1script - please keep them the same.
I don't deploy with this method, so it's not worth my time updating and testing it. The changes in this pull request fixed the issues of getting SD inside docker within my WSL instance.
I don't see the following in the README.md
wsl -d $distro -e sh -c "docker volume create --driver local --opt type=none --opt device=/home/sd/stable-diffusion-webui --opt o=bind sd_vol"
Do what you want with this pull request.
EDIT: Not trying to be a dick, just don't have the time to test this :(
docker/run.sh
Outdated
| docker start --gpus all sd |
There was a problem hiding this comment.
--gpus flag is not a valid docker start argument, but a docker run
If it does work for you though, please add a failover command, e.g. docker start --gpus all sd || docker start -a sd
There was a problem hiding this comment.
So, this is leftovers from testing, there is no --gpus all. The reason to add it due to this #11
* Update README.md * Update build.sh * Updated to build container so that run.sh works. * Update Dockerfile * Added bc to required files due to error when starting container. * Updated docker scripts and created docker-compose.yml * Added docker-compose.override.yml to .gitignore * Updated docker-compose.yml file to use github repository for build versus local.
