Migrate from GMaven to GMavenPlus

[keeganwitt]

Splitting the migration to GMavenPlus in #1742 into a separate PR.

[appiepollo14]

Works perfectly on JDK11!

[keeganwitt]

Works perfectly on JDK11!

Ah, interesting. I was getting some weird Mockito errors I didn't understand on Java 8.

[appiepollo14]

No I'm sorry, It doesn't work like a charm. Mvn clean package does work in fact. But mvn clean install throws the same errors on the integration tests as I've written in my pull request. IMO some groovy exception throwing is different once switching to gmavenplus....?

[appiepollo14]

Checkout master, build with JDK 8, works
Checkout master, build with JDK 11 to java 1.8, exception in phase 'class generation' in source unit, unsupported Target MODULE
Checkout master, build with JDK 11, to java 11, with gmavenplus, throws errors as mentioned earlier.

Any guidance?

[keeganwitt]

I don't understand yet why changing plugins would cause a change in behavior. The only thing I can guess is that there's different versions of Groovy dependencies on the classpath during compilation, but I haven't found them yet.

[appiepollo14]

Hi @keeganwitt did you figure anything out or have any ideas on how to figure it out? If not I'm kinda stuck

[keeganwitt]

Hi @keeganwitt did you figure anything out or have any ideas on how to figure it out? If not I'm kinda stuck

Not yet. I've reached out to the other Groovy devs to see if they have any ideas. This seems very strange.

[keeganwitt]

I can't even build the main branch on Windows, even when using Docker like

docker run --rm -v "${HOME}/.m2:/root/.m2" -v "${pwd}:/project" -w /project maven:3.8-eclipse-temurin-8 mvn clean test

I get multiple package does not exist and "cannot find symbol" compilation errors.

[appiepollo14]

@keeganwitt Im no windhoos user so I can't guide you 🥺

[keeganwitt]

What's strange is I'm getting lots of errors like

[ERROR] /project/modules/json-schema-validator/src/main/java/io/restassured/module/jsv/JsonSchemaValidator.java:[188,29] cannot find symbol
[ERROR]   symbol:   class JsonSchemaFactory
[ERROR]   location: class io.restassured.module.jsv.JsonSchemaValidator

And neither JsonSchemaFactory or JsonSchemaValidator are Groovy classes.

[keeganwitt]

Integration tests are failing, but compilation is succeeding.

[johanhaleby]

What's the status here? Can we get the tests to work? I would love to make this switch.

[keeganwitt]

I'm having trouble understanding why it is the tests are failing. I need to understand the tests better I guess.

[appiepollo14]

@johanhaleby can you take a look and explain the tests that are failing. Or determine whether they fail as expected or because of the gmaven upgrade and wether we should change the tests accordingly.

[keeganwitt]

I'm not sure why. But the tests on this branch pass when I run them in an Ubuntu VM. It appears the tests require they be run on Linux.

[keeganwitt]

I created #1757 to ensure the changes run successfully before merging.