Cross compile to Scala 2.11, 2.12 & 2.13 #1670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have actually just now realized, that the scala support... it's quite an empty project. What's it purpose? It causes more confusion then actually it has to offer. Should we delete it? |
|
Thanks a ton for your effort, but yeah, it's really just a very simple extension function so it might not be worth the effort of maintaining it and introducing all this complexity. For people that want the extension function, maybe it's good enough to just document the code instead and let people copy it to their projects. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #1211
Sorry for copying of the files, but with Maven it will be really difficult to achieve this task.
Maybe splitting scala_support at some point would be more beneficial?
And maintaining it separately? It's not like it is changing a lot.
The CI does not work properly for anything else but JDK8, but in master I see only JDK8 being used...
So I am a bit confused how to work with that, since it fails with newer JDK on parts I did not touch.